bancorprotocol / carbon-app

https://app.carbondefi.xyz
MIT License
24 stars 19 forks source link

Strategy Overview - updating the data and design of the strategy overview card #1336

Open ashachaf opened 3 months ago

ashachaf commented 3 months ago

Goal

to improve the information displayed on the strategy overview card and expose a new value called "Trades" to indicate the number of times a strategy was used in trades.

Design

https://www.figma.com/design/YpsatcY9jtxJr0SJwlFYNj/Carbon-Screen-Design?node-id=13329-123058&t=ZrM49ry8Dog5wP0P-4

Details

API needs

to the existing roi api endpoint, add the value "Trades" which will indicate a simple count of trade times that have used this strategy.

Design changes and display logic

in general, the following design changes should be applied:

The following display logic should be applied: Remove the ROI value.

Update default sort

  1. Add a new sort option "Trades" to the overview card display (explore and my strategies)
  2. When clicked, sort Descending (most trades first)
  3. Update the default sort to use "Trades"