bancorprotocol / carbon-app

https://app.carbondefi.xyz
MIT License
25 stars 17 forks source link

last used pair across all pages #1348

Closed zavelevsky closed 2 months ago

zavelevsky commented 2 months ago

fixes #1331

When visiting the following pages: trade, explore (by pair), simulate, create strategy - the selected pair becomes the default pair.

Note - the current behavior is buggy. If you start to create a strategy and select a pair that doesn't exist yet it becomes the default pair, even if you don't complete the strategy creation - ending up with a bad "empty" experience in other pages. It can also be more problematic with imported tokens etc.

I personally think that strategy creation shouldn't dictate the pair - or it should only take place once the strategy was created - or only if the pair already exists.

cloudflare-pages[bot] commented 2 months ago

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68b7768
Status: ✅  Deploy successful!
Preview URL: https://eafd438a.carbon-app-sei.pages.dev
Branch Preview URL: https://feature-default-pair-1331.carbon-app-sei.pages.dev

View logs

ashachaf commented 2 months ago
cloudflare-pages[bot] commented 2 months ago

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 43c297b
Status:⚡️  Build in progress...

View logs