bancorprotocol / carbon-app

https://app.carbondefi.xyz
MIT License
26 stars 20 forks source link

[E2E] Flacky screenshot #1364

Closed GrandSchtroumpf closed 3 months ago

GrandSchtroumpf commented 3 months ago

We start to see some weird diff in the screenshot where inputs are not filled the same way.

Example: https://github.com/bancorprotocol/carbon-app/pull/1362/files/2a3ae0889353e40fd15916163e7af174ce1251f9#diff-6fad47cf16f451b28370c51d71db80ecababda7ab99bac07642bfde2dbecaa6a

It seems that this commit introduced this behavior: https://github.com/bancorprotocol/carbon-app/pull/1321/commits/bea1c93d3dad400d5bfc6bd5dd25d1dc4b661837

tiagofilipenunes commented 3 months ago

Fixed by https://github.com/bancorprotocol/carbon-app/pull/1357/commits/21753587aa9569a07be44ad1271f66bcfad2b60c