search

bancorprotocol / contracts-solidity

Bancor Protocol Contracts
Other
841 stars 391 forks source link

StandardPoolConverter general improvements #563

Closed barakman closed 3 years ago

barakman commented 3 years ago

In the SP converter and all dependent contracts, replace all dynamic arrays with static arrays of length 2.

lbeder commented 3 years ago

@barakman I have comments, other than:

  1. Considering adding calldata optimization (whenever applicable).
  2. Resolving merging conflict with StandardPoolConverter.sol
barakman commented 3 years ago

@barakman I have comments, other than:

  1. Considering adding calldata optimization (whenever applicable).
  2. Resolving merging conflict with StandardPoolConverter.sol

1 - at https://trello.com/c/vUmFSAJ0 2 - done