search

bancorprotocol / contracts-solidity

Bancor Protocol Contracts
Other
841 stars 391 forks source link

Convert transferPositionAndCall to a more structured transferPositionAndNotify (for hardhat) #619

Closed lbeder closed 3 years ago

sshmaxime commented 3 years ago

Seems like you are putting back the test and contracts files into the old path soldity/test/ or solidity/contracts

lbeder commented 3 years ago

I’ll rename it here as well.

On Wed, 12 May 2021 at 18:15 barakman @.***> wrote:

@.**** requested changes on this pull request.

In test/liquidity-protection/LiquidityProtection.js https://github.com/bancorprotocol/contracts-solidity/pull/619#discussion_r631239271 :

                         });
  • it('should revert when called with invalid call data', async () => {
  • it('should revert when called with an invalid target', async () => {

So why call it 'callback' in one place and 'target' in another?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bancorprotocol/contracts-solidity/pull/619#pullrequestreview-658163145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVVYDSJ7MYTCB7N5J4RRSTTNKZRZANCNFSM44Y6JYPQ .

lbeder commented 3 years ago

Shit, it’s a result of merging master. I’ll fix it.

On Wed, 12 May 2021 at 18:25 Maxime Aubanel @.***> wrote:

Seems like you are putting back the test and contracts files into the old path soldity/test/ or solidity/contracts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bancorprotocol/contracts-solidity/pull/619#issuecomment-839958154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVVYDVOCNXPLWG6SEA6AWDTNK2XZANCNFSM44Y6JYPQ .