Deployment Utility - Githubissues

bancorprotocol / contracts-solidity

Bancor Protocol Contracts

Other

840 stars 391 forks source link

Deployment Utility #623

Closed barakman closed 3 years ago

barakman commented 3 years ago

Extract a deployment utility from the test_deployment script, and use it separately from that script and from a hard-hat test file.

barakman commented 3 years ago

Phase 1:

The hard-hat test executes the Deployment utility using ethers.js functionality.
The deployment script executes the Deployment utility using web3.js functionality.

In phase 2, we may want to consider porting the deployment script from web3.js to ethers.js.

sshmaxime commented 3 years ago

Nice ! Might as well do the phase 2 in this PR no ? @barakman

barakman commented 3 years ago

Nice ! Might as well do the phase 2 in this PR no ? @barakman

I am not yet familiar with signing transactions using ethers.js. I am guessing that it might take a while to implement everything in a relatively robust manner (as robust as it is today, or more).