Closed barakman closed 3 years ago
Yep, totally a non issue 😅
On Mon, 10 May 2021 at 16:47 barakman @.***> wrote:
@.**** commented on this pull request. In src/blockchains/ethereum/converter_version.ts https://github.com/bancorprotocol/sdk/pull/28#discussion_r629472393: @@ -32,7 +32,7 @@ export async function get(web3, address) { const version = await rpc(contract.methods.version()); const value = parse(type, version); if (value) return {type: type, value: value}; return {type: type, value: String(Number(value.split('.').join('')))}; Of course, but I can also use value.split('.').join(''); this is really minor... BTW, I'm on node 12.20.0. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/bancorprotocol/sdk/pull/28#discussion_r629472393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVVYDULYCO22VRAUFWLH7LTM75X5ANCNFSM4RKYWBHQ .
In src/blockchains/ethereum/converter_version.ts https://github.com/bancorprotocol/sdk/pull/28#discussion_r629472393:
@@ -32,7 +32,7 @@ export async function get(web3, address) { const version = await rpc(contract.methods.version()); const value = parse(type, version); if (value) return {type: type, value: value}; return {type: type, value: String(Number(value.split('.').join('')))};
@@ -32,7 +32,7 @@ export async function get(web3, address) { const version = await rpc(contract.methods.version()); const value = parse(type, version); if (value)
Of course, but I can also use value.split('.').join(''); this is really minor... BTW, I'm on node 12.20.0.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/bancorprotocol/sdk/pull/28#discussion_r629472393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVVYDULYCO22VRAUFWLH7LTM75X5ANCNFSM4RKYWBHQ .
Yep, totally a non issue 😅
On Mon, 10 May 2021 at 16:47 barakman @.***> wrote: