Limit Repairs

[cloudflare-pages[bot]]

Deploying with    Cloudflare Pages

Latest commit:	3ee7913
Status:	✅  Deploy successful!
Preview URL:	https://cd9d99ec.phoenix-5t3.pages.dev

View logs

[ashachaf]

• [x] load the preview url and click "limit". there is a console error and nothing happens. if you wait few seconds, it works fine. Uncaught TypeError: Cannot read properties of undefined (reading 'address')
• [x] wallet is not connected and there is a call to GET https://ropsten.etherscan.io/images/main/empty-token.png (return error 503)
• [ ] once you sign the limit order, you get 2 error notifications while the order is actually set (there is an open bug for this)

[pingustar]

503 error for empty-token image will be fixed with PR #543

[zavelevsky]

• [ ] load the preview url and click "limit". there is a console error and nothing happens. if you wait few seconds, it works fine. Uncaught TypeError: Cannot read properties of undefined (reading 'address')

^ this also happens in production - I will fix in a separate PR

• [ ] wallet is not connected and there is a call to GET ropsten.etherscan.io/images/main/empty-token.png (return error 503)

^ @pingustar fixed in a separate PR

• [ ] once you sign the limit order, you get 2 error notifications while the order is actually set (there is an open bug for this)

^ if there's a separate bug I will fix it in a separate PR

==> merging away