bancorprotocol / webapp

Bancor Swap/Analytics webapp
https://app.bancor.network
MIT License
32 stars 45 forks source link

fix 25% => 50% withdrawal bug #1486

Closed Velua closed 3 years ago

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit cb1176c):

https://bancor-v2-beta--pr1486-bug-badformat-nxhm54gb.web.app

(expires Mon, 31 May 2021 17:12:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

ashachaf commented 3 years ago

testing: 100% -> trigger 50% transaction 25% -> trigger 50% transaction 50% -> trigger 25% transaction

pingustar commented 3 years ago

testing: 100% -> trigger 50% transaction 25% -> trigger 50% transaction 50% -> trigger 25% transaction

I figured out what was causing it and fixed it. We locked it the default decimal amount of 50% and then showed the prompt to change the amount which then had no effect because the default amount was already locked in. It is fixed now and I tested it on the preview link, looks good to me. @ashachaf can you confirm that it is working as intended now?

@Velua can you polish this off by triggering the WETH balance to update once the withdraw is confirmed. Currently the site seems to needs a refresh to show the updated WETH balance.

Velua commented 3 years ago

@Velua can you polish this off by triggering the WETH balance to update once the withdraw is confirmed. Currently the site seems to needs a refresh to show the updated WETH balance.

Just pushed in https://github.com/bancorprotocol/webapp/pull/1486/commits/cb1176c3404d7939038585f0a2aa0a4e39f8049e

Good work! @pingustar