search

bancorprotocol / webapp

Bancor Swap/Analytics webapp
https://app.bancor.network
MIT License
32 stars 45 forks source link

metadata endpoint uses an external repository and should use Bancor repo #1578

Closed zavelevsky closed 3 years ago

zavelevsky commented 3 years ago

Describe the bug In https://github.com/bancorprotocol/webapp/blob/master/src/api/observables.ts#L80 we see:

const tokenMetaDataEndpoint =
  "https://raw.githubusercontent.com/Velua/eth-tokens-registry/master/tokens.json";

This repository is now duplicated to the bancor org and you can find it here: https://github.com/bancorprotocol/eth-tokens-registry

So the code should be changed to use: https://raw.githubusercontent.com/bancorprotocol/eth-tokens-registry/master/tokens.json

const tokenMetaDataEndpoint =
  "https://raw.githubusercontent.com/bancorprotocol/eth-tokens-registry/master/tokens.json";

FYI @Ran73Cohen @pingustar @ashachaf

ashachaf commented 3 years ago

@zavelevsky does the new repo includes all images?

zavelevsky commented 3 years ago

@ashachaf the new repo is a git duplicate of the original one