search

bandada-infra / bandada

A system for managing privacy-preserving groups.
https://bandada.pse.dev
MIT License
66 stars 59 forks source link

Add type to group entity #581

Closed waddaboo closed 3 weeks ago

waddaboo commented 1 month ago

Description

This PR adds a new field type to group entity to indicate if a group is an on-chain group or an off-chain group.

Related Issue

Does this introduce a breaking change?

Users must now include type when creating a group.

Example:

await groupService.createGroup(
   {
      name: "Group",
      description: "This is a description.",
      type: "off-chain",
      treeDepth: 16,
      fingerprintDuration: 3600
   }
)

Other information

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:37am
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:37am
vplasencia commented 3 weeks ago

Hey @waddaboo! This file should also be updated to support the new property: https://github.com/bandada-infra/bandada/blob/main/database/seed.sql

Feel free to create a new PR for it.

Also, I just created a new branch called on-chain-invites. We can use that branch to merge all the changes related to the on-chain invite codes feature. Then, when the new feature is ready and working properly in that branch, we can merge it into dev to test in staging and then merge dev into main to have the feature in production.