search

bandada-infra / bandada

A system for managing privacy-preserving groups.
https://bandada.pse.dev
MIT License
66 stars 59 forks source link

Remove global apiSdk variable in test and make it a local constant #587

Closed jaykayudo closed 3 weeks ago

jaykayudo commented 3 weeks ago

Description

Removed the global let apiSdk: ApiSdk and made it local for every test scenerio to make the tests more atomic.

Related Issue

Resolves https://github.com/bandada-infra/bandada/issues/583

Does this introduce a breaking change?

Other information

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 11:00pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 11:00pm
vplasencia commented 3 weeks ago

Hey @jaykayudo could you run yarn prettier:write in the project root and push the changes if only the test file is modified?

gitpoap-bot[bot] commented 3 weeks ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Bandada Contributor:

GitPOAP: 2024 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.