bandada-infra / bandada

A system for managing privacy-preserving groups.
https://bandada.pse.dev
MIT License
64 stars 57 forks source link

MetaMask - RPC Error: execution reverted #599

Open waddaboo opened 1 week ago

waddaboo commented 1 week ago

Describe the bug The error MetaMask - RPC Error: execution reverted will occasionally occur when trying to remove on-chain group members.

To Reproduce Steps to reproduce the behavior:

  1. Go to any on-chain group with member.
  2. Select a member to remove.
  3. Select OK for remove confirmation.
  4. See error Some error occurred! Check if you're on Sepolia network and the transaction is signed and completed.
  5. Browser console will show error MetaMask - RPC Error: execution reverted .

Sometimes the transaction will pass instead of error.

Expected behavior The selected member should be removed successfully without any error.

Screenshots Bandada alert error message image

Browser console error message image

vplasencia commented 1 week ago

This issue is due to the Semaphore Subgraph not working properly after a member is removed, see issue: https://github.com/semaphore-protocol/semaphore/issues/858

Bandada could wait for the issue to be fixed or use the SemaphoreEthers class instead of the SemaphoreSubgraph class here: https://github.com/bandada-infra/bandada/blob/main/apps/dashboard/src/api/semaphoreAPI.ts#L1

Semaphore @semaphore-protocol/data docs: https://github.com/semaphore-protocol/semaphore/tree/main/packages/data#readme