bandang0 / aamg

Automatic Astrophysical Model Generator
MIT License
0 stars 0 forks source link

Add basic functionality #2

Closed gabriel-duque closed 4 years ago

gabriel-duque commented 4 years ago

I just pushed some commits to start the project.

I basically added a skeleton we can build on.

In the source code I:

Everything seems to be fine for now!

This is a draft pull request so we shouldn't set it as mergeable untill it works well.

gabriel-duque commented 4 years ago

CHANGELOG:

bandang0 commented 4 years ago

Hi dude, Thanks for kicking off our project!

I just have a couple of questions:

Technical questions:

Should it be typing.Dict[str, typing.List[str]]?

General questions:

running test WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.

As discussed in this issue of setuptools, the test command will be deprecated in further versions. Should we find some other handle for the tests (now or later)?

Apart from the technical questions, I'm ready to rebase & merge this and address the general questions in later changes.

gabriel-duque commented 4 years ago

I just applied your fixes.