banderson / generator-redux

CLI tools for Redux: next-gen functional Flux/React with devtools
252 stars 36 forks source link

fix: Unhandled 'error' event derails project generation #33

Closed kamijin-fanta closed 8 years ago

kamijin-fanta commented 8 years ago

Issue: #32

events.js:141
      throw er; // Unhandled 'error' event
      ^

TypeError: this.getPackageVersions is not a function
    at deps (C:\Users\kamijin-fanta\AppData\Roaming\npm\node_modules\generator-redux\
generators\app\index.js:121:12)
    at C:\Users\kamijin-fanta\AppData\Roaming\npm\node_modules\generator-redux\node_m
odules\yeoman-generator\lib\base.js:429:16
    at processImmediate [as _immediateCallback] (timers.js:383:17)

reference for: https://github.com/yeoman/generator-generator/blob/d9d604e97b593dabe5f7ba763ae8ff7f73bfd4aa/app/index.js#L16

danielbeutner commented 8 years ago

Worked for me. Thanks! Please merge it

mauricedb commented 8 years ago

+1

banderson commented 8 years ago

@kamijin-fanta I think we need a peerDependency here, otherwise users who are using yo < 1.5 might get the same error in reverse. I'll test this out more tonight and let you know.

kamijin-fanta commented 8 years ago

peerDependency really need?

I tried my code in yo@1.4.7 (released half year ago) But, it was operating succefull, contrary to your expectations.

An error occurred "react-display-name Plugin" so I have removed temporarily from .babelrc. I was fixed in the package downgrade npm i -D babel-plugin-react-display-name@1.0.3

banderson commented 8 years ago

@kamijin-fanta thanks, merging!