banditcpp / bandit

Human-friendly unit testing for C++11
https://banditcpp.github.io/bandit/
Other
259 stars 37 forks source link

headers-only branch is outdated #139

Closed fpoppinga closed 5 years ago

fpoppinga commented 5 years ago

Hello,

the headers-only branch is outdated, and incompatible with the current directory structure in snowhouse.

Reproduce: Install bandit using the submodule approach described on the webpage. You'll not be able to find the snowhouse files referenced from the bandit headers.

sbeyer commented 5 years ago

the headers-only branch is outdated

Oops. Thanks for reminding me. It is now updated.

and incompatible with the current directory structure in snowhouse.

I do not understand this point.

Reproduce: Install bandit using the submodule approach described on the webpage. You'll not be able to find the snowhouse files referenced from the bandit headers.

Just tested and it works.

sbeyer commented 5 years ago

Just tested and it works.

To make this more reproducible, I did the following:

mkdir bandit-headers-only-test
cd bandit-headers-only-test
cat >foo.cc <<X
#include <bandit/bandit.h>

using namespace snowhouse;
using namespace bandit;

go_bandit([] { 
  describe("foo", [] { 
    it("works", [] { 
      AssertThat(true, IsTrue());
    });
  });
});

int main(int argc, char* argv[]) { 
  return bandit::run(argc, argv);
}
X
git init
git add foo.cc
git submodule add -b headers-only https://github.com/banditcpp/bandit bandit
git submodule update --init --recursive
g++ -I. foo.cc 

The last two git lines are the ones that are mentioned in the documentation.

fpoppinga commented 5 years ago

Hi Stephan,

first of all thanks for the really quick response and the update of the headers-only branch, I appreciate it!

Indeed when I'm using the steps you described above, everything worked swimmingly. I conclude that the real issue is with my (sadly highly complex) build setup.

Best Finn