MartinDelille commented 5 years ago

This PR simply replace 0 or NULL by nullptr. It allow compiling the code with the following compiler flags:

-Werror -Wzero-as-null-pointer-constant

I updated the snowhouse version but I guess https://github.com/banditcpp/snowhouse/pull/41 should be merged first.

codecov-io commented 5 years ago

Codecov Report

Merging #142 into master will decrease coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   98.65%   98.64%   -0.02%     
==========================================
  Files          35       34       -1     
  Lines         969      956      -13     
==========================================
- Hits          956      943      -13     
  Misses         13       13

Impacted Files	Coverage Δ
bandit/options.h	`97.82% <100%> (ø)`	:arrow_up:
bandit/runner.h	`90.41% <0%> (-0.38%)`	:arrow_down:
bandit/failure_formatters/qt_creator.h

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a347e77...46841b2. Read the comment docs.

sbeyer commented 5 years ago

Thank you a lot, Martin.

I updated the snowhouse version but I guess banditcpp/snowhouse#41 should be merged first.

Right. There's something to do there. I tell you when you can update this PR. Please also fix the commit message (doubled "fix") then.

MartinDelille commented 5 years ago

Ok I just renamed it.

sbeyer commented 5 years ago

I think you can rebase on latest master.

I tell you when you can update this PR.

This is now. :) (I see that you already did something. I will check later.)

MartinDelille commented 5 years ago

Rebase done!

sbeyer commented 5 years ago

Great, thank you very much!

banditcpp / bandit

Fix zero-as-null-pointer-constant warning #142

Codecov Report