search

banditcpp / bandit

Human-friendly unit testing for C++11
https://banditcpp.github.io/bandit/
Other
260 stars 37 forks source link

Things build and run on vs2015 #75

Closed Stefantb closed 8 years ago

Stefantb commented 8 years ago

Hi Joakim,

I have made some changes that enabled me to build and run the tests using visual studio 2015.

I hope the changes to must and must_not make sense.

The compiler had a strange thing where it could not resolve decltype(expected_exception) without expected_exception being an explicit reference parameter.

I also had to modify the CMakeLists.txt for snowhouse and add a msvc conditional for the warning flags so that would build.

Please take a look if this makes sense to use.

Stefantb commented 8 years ago

The appveyor build fails because of snowhouse. I opened a pull request on the changes needed for snowhouse. If they get accepted then the reference to snowhouse can be updated.

joakimkarlsson commented 8 years ago

Thanks for the effort. I'll take a look at this as soon as possible. It may take a bit as time is precious at the moment.

On Wed, Sep 14, 2016 at 3:54 PM, Stefantb notifications@github.com wrote:

The appveyor build fails because of snowhouse. I opened a pull request on the changes needed for snowhouse. If they get accepted then the reference to snowhouse can be updated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joakimkarlsson/bandit/pull/75#issuecomment-247020044, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF8RIMnoQUiMCOp23gKLCEKVsFH381bks5qp_x8gaJpZM4J7-Pz .

sbeyer commented 8 years ago

Thank you very much, @Stefantb. Since I did not really understand all your changes in this pull request, I went through the appveyor errors step by step and came to the same conclusions but different solutions for the problem. See #79.

All in all most of the problems are produced by old versions of the compilers on appveyor's (and also on travis') VMs. They are both (by far) not C++11-compliant. So a whole different solution would be to update those. However, it is nice if we can still keep some compatibility to old compilers.