banditcpp / bandit

Human-friendly unit testing for C++11
https://banditcpp.github.io/bandit/
Other
260 stars 37 forks source link

Respect background color in info reporter #90

Closed TiloW closed 7 years ago

TiloW commented 7 years ago

Colored output of the info reporter can be hard to read, depending on the terminals background color (e.g., yellow on white).

Also: on Windows, the color in my terminal session is changed permanently after executing tests.

sbeyer commented 7 years ago

I guess using --no-color is not an option?

I doubt there is a portable way to get the terminal's background color. A color remapping option (that allows the user to change colors) is probably too much than we could want but Inspired from vim's set bg=dark and set bg=light, I would probably go so far to enable something like --color=<off|dark|light> and then every supported color has a dark or light representative.

Also: on Windows, the color in my terminal session is changed permanently after executing tests.

That's a separate issue. It's a bug with the Windows colorizer that totally ignores background settings and hence resets them.

sbeyer commented 7 years ago

FYI: I just pushed the branch fix-windows-colorizer. The current only commit banditcpp/bandit@6f8116f5ed84d57d5d9e0ee294c7f3e0c30a402 should not fix your issue but at least should not change background colors now. It is totally untested at the moment.