search

banesullivan / scooby

🐶 🕵️ Great Dane turned Python environment detective
MIT License
47 stars 12 forks source link

Adjust default text_width #11

Closed prisae closed 5 years ago

prisae commented 5 years ago

I have no idea why I have text_width=54 in the versions-script (empymod, emg3d, SimPEG). There must have been a reason. I think too keep it compact.

However, now scooby has several large outputs that then break line ([GCC 7.3.0] in the example below) or overflow (-with-debian-buster-sid in the example below).

This PR sets the default width to 80, which is usually a minimum terminal width; default flake8-width etc.

IPython: Codes-scooby_001

banesullivan commented 5 years ago

Looks good to me!

Should we use textwrap to correct some of those long outputs to fit the set text_width?

prisae commented 5 years ago

It would only be necessary if the output is longer than 80 without a space... You think that is ever the case?

banesullivan commented 5 years ago

I'm think that if a user sets text_width to something shorter, they might expect nothing to exceed that width.

Maybe we should have a conditional incase an output like the platform might exceed the text width then wrap it if so

prisae commented 5 years ago

Ha! Good thinking. Yes please, add that if you know how.