Closed carsten-forty2 closed 4 months ago
Thanks for your PR @carsten-forty2! I like this, what do you think @banesullivan? I do not have Mac/Windows either, but from my perspective we could also pull this in for Linux only, and add other platforms at a later point.
This is a great addition! I have access to a few different machines, architectures, and distributions so I'll do some testing and make sure this works
I made a few changes to support macOS and put all of this in some general try/catch statements to guarantee it doesn't fail. While I added the info for Windows, I did not test this and simply used the return type from docs (I'm too lazy to boot up Windows 🤣, but I'll try to test this on CI or something)
@ThomasMGeo, would you be up for trying this out on Windows and letting us know what's most relevant from import platform;platform.win32_ver()
?
It would be nice and helpful if we also have the name and version for the Linux distribution under OS . It looks like this for my os.
The PR adds some placeholder for other platforms (Mac/Windows/Java) and would need some parsing for these platforms. I don't have access to them to test.
Thanks for considering this PR.
Cheers Carsten