banesullivan / scooby

🐶 🕵️ Great Dane turned Python environment detective
MIT License
47 stars 12 forks source link

Simplifications and clean-up #22

Closed prisae closed 5 years ago

prisae commented 5 years ago

README:

Selection_001

get_version

In [2]: scooby.get_version(numpy) # As already loaded module Out[2]: ('numpy', '1.16.4')

In [3]: scooby.get_version('not_installed') # As string Out[3]: ('not_installed', 'Could not import')

In [4]: scooby.get_version('no_version') Out[4]: ('no_version', 'Version unknown')

In [5]: scooby.get_version('vtk') Out[5]: ('vtk', '8.1.2')



## OTHER:
The idea is, again, to have `scooby` minimal, as a small footprint as possible to be eligible for as many projects as possible.
- Combining files (removed `extras.py` and `mysteries.py`)
- Further cleaning up, simplifications.
- Closes #22, #24.
prisae commented 5 years ago

I created a PyPi-dummy-package no_version so we have a package without __version__ to check.

prisae commented 5 years ago

Hey @banesullivan . I think I am really done now, way more time invested already than planned for it ;-)

Anyway, the PR has a few things mixed up again. If you are only happy with some, but not with other (e.g. the removing of files) then I will split this up.

prisae commented 5 years ago

Yes. Controversially, it is Versions and not Report in SimPEG, empymod, and emg3d.... ;-)

banesullivan commented 5 years ago

and currently generate_report() in PyVista 😏

prisae commented 5 years ago

Well, what do you prefer? For the future? Report I think is good.

banesullivan commented 5 years ago

I think Report is the best - we may want an outside opinion on that later.

When I added generate_report() to PyVista it was because I didn't want another class available at the top level that was not a PyVista mesh type and because I put the interface to scooby in a utilities module that has nothing but functions

banesullivan commented 5 years ago

Everything looks good to me now! When Travis has a check, I'll squash and merge.

Should this jump to version 0.4.0?

prisae commented 5 years ago

Yes, I think so. Thanks!