Switched keys and values

[artistmatej]

Now the keys are on the left side and the values on the right. (Resolve https://github.com/pyvista/pyvista/issues/541)

[banesullivan]

Thanks for taking this on, @artistmatej! I will take a look at this soon and adjust the failing test if needed (I think the test needs to be adjusted for these changes)

[banesullivan]

Also, it would be great to update all of the example outputs in the README (including the screenshot)

[prisae]

I will do tomorrow!

On 10 February 2020 19:31:56 CET, Bane Sullivan notifications@github.com wrote:

banesullivan approved this pull request.

At this point, the changes to the code look good!

We also need the example output in the README to be updated to reflect these changes. Before doing that, I'd like to see if @prisae can do a review on this?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/banesullivan/scooby/pull/42#pullrequestreview-356165145

[prisae]

Thanks @artistmatej

[prisae]

@banesullivan from my point of view it can be merged. You wanted to update the README first, or within this PR?

[artistmatej]

I can update within this PR, I just don't know how to upload the image of Jupyter report. Right now it's in this folder https://github.com/banesullivan/scooby/raw/master/assets/jupyter.png to which I have no access. Or should I just drag and drop and it lands where it lands?

[prisae]

It is in the folder assets in your branch, you should just be able to replace the existing screenshot.

[artistmatej]

Ah, of course. Awesome! Thanks!

[artistmatej]

After all the changes we have made I get this report which is wrong: no_version : Could not import does_not_exist : Could not import

no_version should be 'Version unknown'

In the report with additional

--------------------------------------------------------------------------------
  Date: Wed Feb 12 15:46:07 2020 W. Europe Standard Time

                OS : Windows
            CPU(s) : 16
           Machine : AMD64
      Architecture : 64bit
               RAM : 31.9 GB
       Environment : IPython

  Python 3.7.6 | packaged by conda-forge | (default, Jan  7 2020, 21:48:41)
  [MSC v.1916 64 bit (AMD64)]

           pyvista : 0.23.1
               vtk : 8.1.2
        no_version : Could not import
    does_not_exist : Could not import
             numpy : 1.18.1
             scipy : 1.3.1
           IPython : 7.12.0
        matplotlib : 3.0.3
            scooby : 0.5.0

  Intel(R) Math Kernel Library Version 2019.0.4 Product Build 20190411 for
  Intel(R) 64 architecture applications
--------------------------------------------------------------------------------

[prisae]

no_version is a dummy package, just to show what happens with a package which versioning is bad. You have to install it with pip install no_version. ;-)

[artistmatej]

Haha, that's a funny package. Thanks! Ok, I'll commit the README.md

[prisae]

Thanks @artistmatej !

[banesullivan]

Thanks @artistmatej and @prisae! Looks great!

[artistmatej]

You're welcome and thank you @banesullivan and @prisae for your help and input!