banesullivan / scooby

🐶 🕵️ Great Dane turned Python environment detective
MIT License
47 stars 12 forks source link

Add "File system" as OS/Platform detail #61

Closed PythonFZ closed 3 years ago

PythonFZ commented 3 years ago

We recently encountered an issue which was related to the Filesystem in use. This was related to the use of a NFS File System.

I added this approach https://stackoverflow.com/a/35291824/10504481 from the user gena2x to get the file system.

Tested with:

import scooby
scooby.Report()
--------------------------------------------------------------------------------
  Date: Sun Apr 18 19:47:45 2021 Mitteleuropäische Sommerzeit
                OS : Windows
            CPU(s) : 16
           Machine : AMD64
      Architecture : 64bit
               RAM : 15.9 GiB
       Environment : Python
       File system : NTFS
  Python 3.9.4 (default, Apr  9 2021, 11:43:21) [MSC v.1916 64 bit (AMD64)]
>>> import scooby
>>> scooby.Report()

--------------------------------------------------------------------------------
  Date: Sun Apr 18 19:51:57 2021 CEST

                OS : Linux
            CPU(s) : 32
           Machine : x86_64
      Architecture : 64bit
               RAM : 125.6 GiB
       Environment : Python
       File system : ext4

  Python 3.9.4 (default, Apr  9 2021, 16:34:09)  [GCC 7.3.0]

            scooby : 0.5.7
--------------------------------------------------------------------------------
>>> import scooby
>>> scooby.Report()

--------------------------------------------------------------------------------
  Date: Sun Apr 18 19:52:33 2021 CEST

                OS : Linux
            CPU(s) : 12
           Machine : x86_64
      Architecture : 64bit
               RAM : 15.5 GiB
       Environment : Python
       File System : ext4

  Python 3.9.2 | packaged by conda-forge | (default, Feb 21 2021, 05:02:46)
  [GCC 9.3.0]

            scooby : 0.5.7
--------------------------------------------------------------------------------
prisae commented 3 years ago

That is the issue I mention in the review:

Selection_002

We could maybe change the default ncol to 4? What do you think @banesullivan Selection_003

banesullivan commented 3 years ago

I agree with changing the default ncol to 4

PythonFZ commented 3 years ago

That is the issue I mention in the review:

Selection_002

We could maybe change the default ncol to 4? What do you think @banesullivan Selection_003

I'd like to add that in the case of dark mode, the default color scheme for Jupyter Lab is difficult to read. This isn't an open issue currently but may be worth a consideration. image

prisae commented 3 years ago

LGTM, you can merge this @banesullivan .

Good catch @PythonFZ regarding colour scheme. Could you open a new issue for that? We should maybe check how others do it with fanry html-reprs, e.g., xarray or similar.