Patch for #75: File system seg fault on Windows

[banesullivan]

I went ahead and just skipped this for Windows altogether, what do you think, @Huite and @akaszynski?

Resolves #75, resolves https://github.com/pyvista/pyvista/issues/1961

[codecov-commenter]

Codecov Report

Merging #76 (3c80051) into main (5f534e2) will increase coverage by 0.55%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   86.50%   87.05%   +0.55%     
==========================================
  Files           4        4              
  Lines         363      363              
==========================================
+ Hits          314      316       +2     
+ Misses         49       47       -2     

[akaszynski]

Agreed, especially considering the severity of this bug.

[banesullivan]

Did a little refactor too

[akaszynski]

Looks good.

[banesullivan]

Before I merge and release, @Huite, do you think you'll have a chance to double check this on your system that experiences the seg fault?

[Huite]

I don't think I can -- I won't be at the office for the next two weeks, and unfortunately I'm unable to reproduce it at home (fiddled with several USB, but to no avail). So January 11th is likely the first opportunity I'd get to test.

(Changes look good to me.)

[banesullivan]

Okay, thanks for letting me know. I'll go ahead within merging and releasing as this should simply disable the feature for Windows altogether. we can always update later to optionally enable on windows

[Huite]

Back at the office, I just tested it: the fix works, I was segfaulting on 0.5.10 and pip install scooby=0.5.11 fixes it.