search

banesullivan / scooby

🐶 🕵️ Great Dane turned Python environment detective
MIT License
47 stars 12 forks source link

Improve HTML formatting #82

Closed akaszynski closed 2 years ago

akaszynski commented 2 years ago

Resolve #62 by removing the hard-coded table color.

Improves HTML report by forcing two columns to make the package listing more readable.

image

prisae commented 2 years ago

I like the colours, thanks @akaszynski

I would be a bit more cautious personally for the two-column change. It is quite a change. Could it be a keyword-change instead, eg scooby.Report(twocolumn={False}/True). (Just that I personally quite like the multi-col style, so I'd prefer to keep it.)

prisae commented 2 years ago

Could we split your two points, (1) remove hard-coded table color and (2) force two columns, into two separate PR's? I think (1) would be just ready to go, whereas (2) I am personally against, or it would need at least some discussion and thinking and agreeing IMHO.

prisae commented 2 years ago

Is it OK to close this one @akaszynski in favour of #88 and potentially #89 ?

akaszynski commented 2 years ago

Is it OK to close this one @akaszynski in favour of #88 and potentially #89 ?

Absolutely. #88 is better.