search

banesullivan / scooby

🐶 🕵️ Great Dane turned Python environment detective
MIT License
47 stars 12 forks source link

Fix #95 #96

Closed prisae closed 2 years ago

prisae commented 2 years ago

Can you test if that works in your env @banesullivan ?

Closes #95

prisae commented 2 years ago

(If possible, I'd like to get #93 in before this one.)

banesullivan commented 2 years ago

I'll see if I can reproduce this again... it happened in a pretty complex CI env I was debugging and ended up changing a lot. Or perhaps this might just happen anytime MKL is not installed? I'll find out

prisae commented 2 years ago

Or perhaps this might just happen anytime MKL is not installed?

No, I checked that. If mkl is not installed, it works fine. It must be a weird setup where either mkl.get_version_string() or numexpr.get_vml_version returned None.

However, I think the change in this PR makes the code cleaner, and it should catch this rare case as well.

prisae commented 2 years ago

I'll bring that in, whether it fixes it or not, as I think it is better either way.