search

bang-olufsen / yahdlc

yahdlc - Yet Another HDLC implementation
MIT License
82 stars 27 forks source link

Added support for 32-bit CRC. #11

Closed SuperGeek9000 closed 4 years ago

SuperGeek9000 commented 4 years ago

Hi guys! I have been using YAHDLC for a while now and it works great! Thank you so much for publishing and sharing your work! I have tested the code I added within my own framework, and it works perfectly. However, I tried to check if the tests that you have added in the repo still work, but I couldn't run the tests because I don't have the boost_unit_test_framework and I didn't want to install it. Maybe you can check if the tests also work with the CRC32 version.

Thanks a lot and have a great day!

wiktordrewniak commented 4 years ago

Check: https://travis-ci.org/github/bang-olufsen/yahdlc

SuperGeek9000 commented 4 years ago

"make coveralls" fails because no REPO_TOKEN is defined: coveralls-lcov -t report.info

What is this REPO_TOKEN and how should I define it?

jeppefrandsen commented 4 years ago

@jeppefrandsen Awesome! Thanks for your fast reply! :)

Just checked the travis-ci permissions to the token and it should be available to all branches so needs more investigations. But think with the below fix we should be able to merge it anyway. These changes should not impact coverage 👍

SuperGeek9000 commented 4 years ago

@jeppefrandsen Awesome! Thanks for your fast reply! :)

jeppefrandsen commented 4 years ago

@SuperGeek9000 thanks for the PR 🍻