search

bangalore-haskell-user-group / functorrent

A bit torrent client
GNU General Public License v3.0
18 stars 9 forks source link

Should we checkin cabal.config? #16

Closed vu3rdd closed 9 years ago

vu3rdd commented 9 years ago

According to this article on stackage, we can checkin the generated cabal.config so that others can reproduce the exact build setup along with dependencies.

Does anyone see any reason why it shouldn't be checked in?

jaseemabid commented 9 years ago

@vu3rdd I did think of the same. Since we refer to lts, and a new lts release is not a very frequent thing, we should be fine either way.

jaseemabid commented 9 years ago

@vu3rdd Lets check in. This will ensure travis/any CI will build the same thing as local. We can update the file per LTS release.

jaseemabid commented 9 years ago

Fixed at https://github.com/vu3rdd/functorrent/pull/30