banillie / analysis_engine

Place for all code used to compile the quarterly PfM Report, manage GMPP data, as well as other useful data searching/analysis functions.
MIT License
2 stars 2 forks source link

Issues from ver 0.0.10 testing #19

Closed banillie closed 3 years ago

banillie commented 3 years ago

risks fixed. Test with ver 0.0.11 when released. DONE query fixed. Test with ver 0.0.11 when released. DONE dandelion fixed. Test with ver 0.0.11 when released. DONE matrix not working don't yet have a time frame for completion. to be set by team. dashboards working but, need user messaging to help ensure correct master file in the input folder. for ver 0.0.12 DONE speedials and summaries same as for dashboards user messaging to help ensure summary_temp doc in input folder. for ver 0.0.12 DONE

Testing raised issue with rendering process and use of pdf2image raising the following error

pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?

good place to start answering this is here https://stackoverflow.com/questions/53481088/poppler-in-path-for-pdf2image

@yulqen would be grateful for your thoughts on this. The team needs to be able to simply install necessary requirements as part of the pip install analysis_engine process and it's not ideal if they need to mess around with paths. I don't have this issue on Ubuntu. DONE manual fix was necessary

yulqen commented 3 years ago

https://pypi.org/project/pdf2image/

Windows requires manual installation of this package. Don't think you have much choice. How important is pdf2image? I remember you mentioning it re JPGs or something.

banillie commented 3 years ago

Yeah it's pretty important. It keeps the rendering of graphical images to a high quality. I could find another solution/package for helping me with this, but I don't remember seeing any other obvious solutions when I was working onto it! How difficult will it be to get the team to do it manually? Would you be able to do a demo for me?

yulqen commented 3 years ago

I'm sure I could.

yulqen commented 3 years ago

Try this:

Let me know if further problems.

banillie commented 3 years ago

Yeap that worked. Need to do a bit of further testing/implementation with the laptops for the rest of the team, but hopefully should be resolved.

banillie commented 3 years ago

Two outstanding actions before closing:

banillie commented 3 years ago

Documentation update done.