banillie / analysis_engine

Place for all code used to compile the quarterly PfM Report, manage GMPP data, as well as other useful data searching/analysis functions.

MIT License

2 stars 2 forks source link

Json master data structure tests #20

Closed banillie closed 3 years ago

banillie commented 3 years ago

Look at and potentially refactor the process for storing master data in a json data structure format.

banillie commented 3 years ago

17 is relevant here.

yulqen commented 3 years ago

bcompiler-engine already temporarily creates a JSON structure before building the master spreadsheet. It shouldn't be a massive effort to create a new output format for datamaps, to produce a JSON file, which you can do what you like with in analysis_engine. We need to discuss this week if possible.

banillie commented 3 years ago

Great. You've preempted me asking you how how bcompiler-engine handles json data files. I tried putting a Datamaps Master into a json file and got an error message because it's a Class. But, I also got an error when I tried to dump the Master.data dict into json, so probably doing something wrong there. There is a lot of useful information in the Master Class though e.g projects and quarter, which it would be good to have access to you. Anyway yes let's discuss. This isn't something I was going to do immediately, more of a medium term improvement and I won't start on it until we've discussed.

banillie commented 3 years ago

Discussed with @yulqen on 23 April. Steps to take are:

develop function for data dump into Json file. Highlighted that previous problem was due to datetime objects not being json serializable. got a way forward on that now.

banillie commented 3 years ago

Completed!