Licence missing in the rubygems version and in the gemspec

[mensfeld]

The "method_source" gem seems not to have a license at all. Unless a license that specifies otherwise is included, nobody else can use, copy, distribute, or modify that library without being at risk of take-downs, shake-downs, or litigation.

I know, that this gem has a license on github, however it's missing one at rubygems and in a gemspec.

[banister]

It does have a license as of 0.9.0 release, you must be looking at an old version?

[1] pry(main)> gem-cd method_source
/Users/john/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/method_source-0.9.0
[2] pry(main)> .ls
Gemfile         README.markdown     lib         spec
LICENSE         Rakefile        method_source.gemspec
[3] pry(main)> cat LICENSE
License
-------

(The MIT License)

Copyright (c) 2011 John Mair (banisterfiend)

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
'Software'), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
[4] pry(main)>

[mensfeld]

Not in the gemspec definition that is used in rubygems api:

https://rubygems.org/gems/method_source => Licence: N/A

for example: https://github.com/banister/method_source/blob/master/method_source.gemspec and https://github.com/karafka/karafka/blob/master/karafka.gemspec#L17 (line 17)

[banister]

Alright, well, that's a matter of convenience and discoverability -- but the fact that we distribute a license with the gem should be enough to put your concerns about legal action at bay :)

However, if you want to open a PR adding a license to the gemspec, i would merge it :)

But please note that our gemspec is generated so you should add the license to the Rakefile in the apply_spec_defaults method, https://github.com/banister/method_source/blob/master/Rakefile

[mensfeld]

@banister ok, I will submit a PR as it breaks our code checking tools as they use rubygems api for discovery.

[banister]

Thanks

[mensfeld]

Thank you for this gem. It's really helpful and definitely underrated in terms of stars ;)