Icon Sidebar: Add back the "Star" section, where to display your Starred/Favorite Contacts

star-buck commented 6 years ago

That entry should be the FIRST icon at the top of the sidebar. It should display only starred contacts, otherwise look like "All Contacts".

Elv13 commented 6 years ago

Do you prefer a subset of the timeline or the alphabetical order? It doesn't change much from an effort PoV. The feature is not gone, it's just commented. You can even make the panel show up in the "Menu->View->Bookmark". Disabling the bookmark was done at your request https://github.com/ring-project/ring/issues/18#issuecomment-327841892 (at least my interpretation of it). But I agree it is useful enough to be enabled by default.

star-buck commented 6 years ago

Lets enable it and see.

Elv13 commented 6 years ago

Update:

I ended up rewriting the entire bookmark support backend. The code was a decade old and not very QML/Kirigami/Mobile friendly (as in: very slow and code-rotten).

screenshot_20180209_185058

New features:

Removing bookmarks actually works, apparently it never worked before...
The ability to automatically generate the bookmarks from the most contacted people is configurable (and disabled by default) instead of always on. If you think it should be enable by default, just say. Once upon a time it was enabled by default because office users got better SIP metadata tracking for bookmarked peers. This is a protocol thing and should not cause changes to Ring-KDE UX.

What's left to do / fix:

The "by date" version
The search
Re-enable the sorting proxy
Maybe add the ability to assign bookmarked contacts to keyboard shortcuts again. This was removed in the big "delete all the code for call centers" milestone as it would have taken too much effort to port
Maybe add a big (+) button like the dial view to add new bookmarks?

I will go back to the wizard bug now.

Elv13 commented 6 years ago

Also not ready, there is more issue than just the "it does nothing on click". The sorting isn't done and the search doesn't support bookmarks yet

star-buck commented 6 years ago

Please add single tickets then, i dont like big tickets with all kinds of lists and sublists.

star-buck commented 6 years ago

sorting and search arent necessary right now, there are other more important bugs and real issues.

banji-project / ring-issues

Icon Sidebar: Add back the "Star" section, where to display your Starred/Favorite Contacts #23