banji-project / ring-issues

Old issues before it was moved to kde.org
0 stars 0 forks source link

sliding sidebar: add account info #27

Closed star-buck closed 6 years ago

star-buck commented 6 years ago

add account info of user who is using this account somewhere in that sidebar (above or at bottom): screenshot_20180209_144455

Elv13 commented 6 years ago

screenshot_20180214_221820

Elv13 commented 6 years ago

I am doing making most of the related classed QML firendly. There is a little Kirigami issue where the action handles y position currently depend on the item height. This causes them to be misaligned when the height isn't constant. I will submit a kirigami patch for and wait until the next framework release before applying the change to ring-kde to avoid a dependency on Kirigami2-git

The Kirigami actions on swipe are:

To do:

Edit (Thursday), more issues in need of attention:

Edit (Monday):

Elv13 commented 6 years ago

This was quite a rabbit hole and it's still is. To get the "spirit" of the issue, it pulled quite a lot of things. So the account in the sidebar is implemented and now is correctly updated when there is issues.

Then I went further and implemented the mockup part with the profile status in the dock bar so it becomes visually obvious when there is a problem. I knew the profile support was in bad shape, but this was beyond bad. 3 people implemented part of the stack and had 3 totally different understanding of the "correct behavior":

All 3 are defensible as "good ideas". However all 3 were assumed in different part of the code. The result was that a random profile was sent depending on how the person was reached. So private data could simply be uploaded randomly, including to strangers. That's fixed.

Then I went further and tried to fix the account presence so it could be controlled from the sidebar too (present, away, busy, etc). That's in spectacularly bad shape and the more I look at it, the more it seems the way the whole protocol extension has been designed is one giant leak of personal metadata. I will take another look tomorrow to make sure I didn't miss anything, but it doesn't even look like it's fixable at all while supporting existing GNU Ring users.

So the issue is mostly done, but I would still like to implement better problem mitigation so issues like #28 are easier to diagnose.

After that, unless you ask me to keep going, I will call this complete since otherwise it will take an undefined amount of time for a diminishing return on investment. The whole account subsystem is still using the old QtWidget dialogs and everything and I still plan to keep it that way for 3.0 and 3.1.

Changes since alpha3: