search

bank-vaults / vault-helm-chart

A Helm chart for installing Hashicorp Vault
Apache License 2.0
9 stars 6 forks source link

feat: Allow Velero container creation #26

Closed tanmay-pnaik closed 9 months ago

tanmay-pnaik commented 1 year ago

Allow Velero container creation without the use of CRDs

Referred to config at https://github.com/bank-vaults/vault-operator/blob/main/pkg/controller/vault/vault_controller.go

ramizpolic commented 11 months ago

Great work @tanmay-pnaik, would you mind rebasing with latest changes? Sorry for a late reply on this, we have been working on features and fixes across other repos.

tanmay-pnaik commented 11 months ago

Great work @tanmay-pnaik, would you mind rebasing with latest changes? Sorry for a late reply on this, we have been working on features and fixes across other repos.

Done!

akijakya commented 11 months ago

Great work @tanmay-pnaik, would you mind rebasing with latest changes? Sorry for a late reply on this, we have been working on features and fixes across other repos.

Done!

Hi @tanmay-pnaik, sorry for the inconvenience but merge commits are not allowed on feature branches, could you please remove those and rebase onto main instead? Thanks!

ramizpolic commented 11 months ago

Can we also move the templates into a separate PR?

tanmay-pnaik commented 11 months ago

Great work @tanmay-pnaik, would you mind rebasing with latest changes? Sorry for a late reply on this, we have been working on features and fixes across other repos.

Done!

Hi @tanmay-pnaik, sorry for the inconvenience but merge commits are not allowed on feature branches, could you please remove those and rebase onto main instead? Thanks!

Done!

tanmay-pnaik commented 11 months ago

Great work @tanmay-pnaik, would you mind rebasing with latest changes? Sorry for a late reply on this, we have been working on features and fixes across other repos.

Done!

Hi @tanmay-pnaik, sorry for the inconvenience but merge commits are not allowed on feature branches, could you please remove those and rebase onto main instead? Thanks!

Done!

Can we also move the templates into a separate PR?

Done, see https://github.com/bank-vaults/vault-helm-chart/pull/33

ramizpolic commented 9 months ago

@tanmay-pnaik If it's okay with you, we can close this one. I created https://github.com/bank-vaults/vault-helm-chart/issues/83 to track the other issue. Sorry for the hassle :(