search

bank-vaults / vault-helm-chart

A Helm chart for installing Hashicorp Vault
Apache License 2.0
8 stars 3 forks source link

Rename unsealer.image to bankVaults.image #29

Open sagikazarmark opened 11 months ago

sagikazarmark commented 11 months ago

Currently both the configurer and unsealer use the unsealer image config.

Rename it to bankVaults so that naming makes more sense.

tanmay-pnaik commented 11 months ago

This should be backwards compatible like: https://github.com/bank-vaults/vault-operator/commit/203082cb6b5031b9d53e90dc8519d692e5002fdd

sagikazarmark commented 11 months ago

Yes, it should.

tanmay-pnaik commented 11 months ago

I can help with this. :+1:

sagikazarmark commented 11 months ago

Appreciate it, thank you!

tanmay-pnaik commented 11 months ago

@sagikazarmark Should this be implemented only for https://github.com/bank-vaults/vault-helm-chart/blob/main/vault/values.yaml#L250-L254 or for the entire unsealer block i.e. https://github.com/bank-vaults/vault-helm-chart/blob/main/vault/values.yaml#L250-L276? The former is pretty straightforward.

sagikazarmark commented 11 months ago

Good question...

I'd say it would be ideal if we could have a common block for everything that's shared between the unsealer and the configurer, but I can see why that could prove challenging.

Maybe we could use templating to filter the relevant keys from the unsealer section and recursively merge it with a new bankVaults section. I think that should be possible using template functions.

tanmay-pnaik commented 11 months ago

Having an issue with creating a template for unsealer.args, will work on it for some time.

ramizpolic commented 9 months ago

Hi @tanmay-pnaik, thanks for the interest, do you still need help with this? I can assist you and help out with setting everything up.

tanmay-pnaik commented 8 months ago

Hi @tanmay-pnaik, thanks for the interest, do you still need help with this? I can assist you and help out with setting everything up.

@ramizpolic That would be helpful. I'll raise a PR with my current changes and maybe we could then take it forward?

ramizpolic commented 8 months ago

Sounds good, whenever you are ready @tanmay-pnaik

github-actions[bot] commented 5 months ago

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 20 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.