Peer to peer code review

banlon-jones / awesome-books-es6

2 stars 1 forks source link

Peer to peer code review #2

Open guerreiropedr0 opened 2 years ago

guerreiropedr0 commented 2 years ago

I think that you should either update the README.md file so we know the dependencies or you fix the live demo project.

DeVuDeveloper commented 2 years ago

The codebase is clean, only issue lives -preview on git hub is not working, because importing luxon throw an error that can be fixed importing luxon from CDN as an object equal to the window. But Jones made it as requirements for projects says import luxon with npm.

tresorsawasawa commented 2 years ago

Great job with your code :100:, it is looking perfect and clean. However, there is something you should work on:

[ ] I think it will be better to make make your live link working and make it a hyperlink in text, so it will look professional