search

bannertime / generator-bannertime

Yeoman generator to help build and manage HTML5 banner campaigns.
https://bannertime.github.io/
58 stars 35 forks source link

fix: banner not centred in preview layout #101

Closed joemidi closed 6 years ago

joemidi commented 7 years ago

I don't think we need the following position in the base/main.js

TweenLite.set(banner, {top: 0, right: 0, bottom: 0, left: 0, position: 'absolute', margin: 'auto'});

as it shifts the banner to the wrong centre from the new .banner positioning below:

.banner {
  transform: translate(-50%, -50%);
  left: 50%;
  top: 50%;
}
joemidi commented 6 years ago

This was fixed with commit ca8d0553e6f0fbb5ce5e88b53295a771cdcd4db5.