bannertime / generator-bannertime

Yeoman generator to help build and manage HTML5 banner campaigns.
https://bannertime.github.io/
58 stars 35 forks source link

Not using images, what to do. #102

Closed rgfx closed 7 years ago

rgfx commented 7 years ago

I am using an inline SVG, when I comment out the image array the banner breaks. I tried removing everything that references image preloading and still having issues. Surely I can't be the only one that doesn't use images.

this.images = [
//'images/logo.png'
];

Please advise.

joemidi commented 7 years ago

Hmm,

This should work:

  // Image array for preloading
  // this.images = [
  //   'images/logo.png'
  // ];

  // var _this = this;
  // this.preloadImages(this.images, function () {
    this.createElements();
    this.setup();
    this.hidePreloader();
    this.animate();
    this.bindEvents();
  // });
rgfx commented 7 years ago

That works

I had to uncomment var _this = this;

Thanks.