bannertime / generator-bannertime

Yeoman generator to help build and manage HTML5 banner campaigns.
https://bannertime.github.io/
58 stars 35 forks source link

issue: EBLoader.js needs to be on the root #115

Closed adam-hite closed 6 years ago

adam-hite commented 6 years ago

According to Sizmek's documentation: 2

It currently lives in the js folder.

I'm getting this error in Sizmek: 1

joemidi commented 6 years ago

Hey @adam-hite

I think you may simply need to add the script tag to the index.html

<script src="js/EBLoader.js" type="text/javascript"></script>

From there it should pick it up.


Tested on generator version 3.0.2 using the following:

$ yo bannertime:new
>
? Set the width of the banner: 300
? Set the height of the banner: 600
? What is the name of the new format? (kebab-case) sizmek-test-300x600
? What type of banner is it? Sizmek
adam-hite commented 6 years ago

Sizmek wants the file to be in the root, not in the js folder. The script tag is pointing to the js folder.

joemidi commented 6 years ago

I've just tested a fresh campaign with 3.0.2 using these files: sizmek-test-300x250.zip

screen shot 2018-03-08 at 09 24 14

From what I can tell it works fine with the EBLoader.js sitting in the /js folder and the script tag as:

<script src="js/EBLoader.js" type="text/javascript"></script>

I would also note that the error message in your second image explicitly says within the root HTML file rather than the root folder/workspace: The include of the adkit.js or EBLoader.js is missing in the root HTML file.

danielhauchler commented 6 years ago

You can also use:

 <script src="./EBLoader.js" type="text/javascript"></script>
joemidi commented 6 years ago

@danielhauchler Sure, it doesn't really matter where you put the file, as long as you reference it with a script tag in the root HTML file.

We've just placed it inside the /js folder so that it structurally makes sense.

joemidi commented 6 years ago

Closing this as it works as intended.