search

bannertime / generator-bannertime

Yeoman generator to help build and manage HTML5 banner campaigns.
https://bannertime.github.io/
58 stars 35 forks source link

Upgraded to the last version but now getting an ERROR #136

Open superalitos opened 4 years ago

superalitos commented 4 years ago

main.js:232 Uncaught TypeError: Cannot read property 'removeEventListener' of undefined at Scrubber._destroy (main.js:232) at Preview._onClick (main.js:62)

I've had to comment out the first line of this function... resulting in the 'scrub' drag preview not working correctly. Please fix ASAP. thanks

Scrubber.prototype._destroy = function() { // TweenLite.ticker.removeEventListener('tick', this._scrub);

lipovskoy commented 3 years ago

Any solution to this?

Chris-DuCharme commented 3 years ago

I'm having the same issue as well.

The issue appears to be this second of code is not formatted for GSAP 3.

gsap.ticker.addEventListener('tick', this._scrub);

Should be something like:

gsap.ticker.add("tick", this._scrub);

And:

TweenLite.ticker.removeEventListener("tick", this._scrub);

Should be something like: gsap.ticker.remove(this._scrub);

However, now I'm getting a new set of errors.

It looks too me like a bit of work still needs to be done to make this fully compatible with GSAP 3.x

If I figure this out and get it working I'll report back here.

lipovskoy commented 3 years ago

I'm having the same issue as well.

The issue appears to be this second of code is not formatted for GSAP 3.

gsap.ticker.addEventListener('tick', this._scrub);

Should be something like:

gsap.ticker.add("tick", this._scrub);

And:

TweenLite.ticker.removeEventListener("tick", this._scrub);

Should be something like: gsap.ticker.remove(this._scrub);

However, now I'm getting a new set of errors.

It looks too me like a bit of work still needs to be done to make this fully compatible with GSAP 3.x

If I figure this out and get it working I'll report back here.

The creators will not be making any major updates so Im not using the generator anymore.