feat: when using copytime additional js references are not copied

bannertime / generator-bannertime

Yeoman generator to help build and manage HTML5 banner campaigns.

https://bannertime.github.io/

58 stars 35 forks source link

feat: when using copytime additional js references are not copied #86

Open joemidi opened 7 years ago

joemidi commented 7 years ago

Currently, the way copytime works any additional js files added to the head are not copied over to the new format.

MandyJansen commented 6 years ago

Is this going to be resolved? Probably not as it's been way over a year...

joemidi commented 6 years ago

Eek! Sorry @MandyJansen, @pyramidium and I are pretty busy with other projects. If you could send us a PR we could merge it in?

joemidi commented 6 years ago

@pyramidium Could we parse src/${this.props. bannerMaster}/index.html for script tags that are not found in the Bannertime framework, e.g.: Enabler.js, EBLoader.js, AdformDHTML.js, banner.js, banner.loader.js, banner.animation.js and then add those to the this.fs.copyTpl() ?

Perhaps we can add a conditional check to the Promt.js so that once a user selects a banner, we scan it for extra JS files?