bannzai / SpreadsheetView

Full configurable spreadsheet view user interfaces for iOS applications. With this framework, you can easily create complex layouts like schedule, gantt chart or timetable as if you are using Excel.

MIT License

3.52k stars 458 forks source link

Fix touches not work after first touch be canceled #265

Closed marcuswu0814 closed 4 years ago

marcuswu0814 commented 4 years ago

Seems a wrong method call after this change: https://github.com/Golface/SpreadsheetView/commit/dff8da74377572fae16008f96d34e8e56d14b745

May fix this issue.

marcuswu0814 commented 4 years ago

Hi @bannzai , I think this is a high priority issue. Would you please help to review and release. 😀

bannzai commented 4 years ago

Hi, @marcuswu0814 Thanks for your great contributions! LGTM for your PR changes. But I will fix error about github actions at first. Ref: https://github.com/bannzai/SpreadsheetView/pull/266.

Could you rebase for this PR branch after I solved the github actions issue? I will mentioned you after solved the github actions problem. After that, I will confirm issue problem and do manually testing. So please wait for a while.

bannzai commented 4 years ago

@marcuswu0814 I solved github actions error. Could you rebase on master or merge master to this PR branch and push again? After push again, I guess to pass failure tests.

codecov-io commented 4 years ago

Codecov Report

Merging #265 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files           8        8           
  Lines         132      132           
=======================================
  Hits          124      124           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb72340...18d3b1e. Read the comment docs.

marcuswu0814 commented 4 years ago

Hi @bannzai, it seems work. 😀 Maybe this PR should be merge and release a new pod version ASAP. 😅

bannzai commented 4 years ago

Thank you ! I will merge and release soon!