search

banool / codenames-pictures

Play Codenames Pictures using a TV or computer for the board
https://codenames-pictures.dport.me
22 stars 18 forks source link

Use window origin instead of window host for header link #26

Closed jackwilsdon closed 6 years ago

jackwilsdon commented 6 years ago

This change means we no longer need to prefix a protocol, as origin already includes it.

I noticed this when testing as I am not hosting the application over HTTPS, and it was taking me to a HTTPS URL when clicking the header.

banool commented 6 years ago

Have you tested this as working when running as a prod server on 80 / 443 as well as in development on some random port (e.g. 8001). I can't imagine why it wouldn't work but you don't know.

jackwilsdon commented 6 years ago

Just tested it with ngrok and it works fine over both HTTP (port 80) and HTTPS (port 443). In development I've tested it on ports 9001 and 3000 and all seems good :+1:

banool commented 6 years ago

Neat thanks for all the work on this!