Closed colossatr0n closed 2 years ago
Thanks a lot for all of these changes, this is a much needed quality of life improvement. I don't have any major changes I'd like to see, just some nits.
No problem! Thanks for maintaining this repo.
Have you verified that the output without the new flags is the same and still works with the notifier?
Let me double check.
Thanks for checking. I'd love to make the notifier take some structured input, json at the least, to make changes to the main script less likely to break it. As it is now, it does very janky parsing of the human readable output. But for now we have to be careful.
Output without the new flags is the same and the notifier still works.
Perfect. Rebase this PR since there are conflicts and then we'll be good to go.
Rebased 👍
Thanks for working on all these changes!!
You're welcome! Thanks for accepting the PR.
Refactored specifying campsite IDs. Original implementation was done by BillXMA here.
Added argument to output campsite IDs with their availability (--show-campsite-info):
Site 69800 is available on the following dates:
Refactored camping.py:
Added tests.