banool / recreation-gov-campsite-checker

Scrapes the recreation.gov website to check for campsite availabilities 🏕🏕
Apache License 2.0
324 stars 166 forks source link

Refactored @BillXMA availability PR, added tests, and refactored camping.py #44

Closed colossatr0n closed 2 years ago

colossatr0n commented 2 years ago
colossatr0n commented 2 years ago

Thanks a lot for all of these changes, this is a much needed quality of life improvement. I don't have any major changes I'd like to see, just some nits.

No problem! Thanks for maintaining this repo.

Have you verified that the output without the new flags is the same and still works with the notifier?

Let me double check.

banool commented 2 years ago

Thanks for checking. I'd love to make the notifier take some structured input, json at the least, to make changes to the main script less likely to break it. As it is now, it does very janky parsing of the human readable output. But for now we have to be careful.

colossatr0n commented 2 years ago

Output without the new flags is the same and the notifier still works.

banool commented 2 years ago

Perfect. Rebase this PR since there are conflicts and then we'll be good to go.

colossatr0n commented 2 years ago

Rebased 👍

banool commented 2 years ago

Thanks for working on all these changes!!

colossatr0n commented 2 years ago

You're welcome! Thanks for accepting the PR.