search

banteg / multicall.py

aggregate results of multiple smart contract calls into one
MIT License
246 stars 106 forks source link

add feature to get block id from last call #23

Closed 007vasy closed 2 years ago

007vasy commented 2 years ago

for retrieving archival information it is useful to have the latest block id available to pinpoint when the data was fetched also it allows to do multiple calls on the same block id (for example fetch all uniswap pools at one block id in multiple batches)

BobTheBuidler commented 2 years ago

Wouldn't you determine the blockid with your script, and pass that value in to the multicall lib? Unsure of the use case but definitely curious to understand why this is needed from your PoV.

BobTheBuidler commented 2 years ago

also is your PR #24 intended to render this PR obsolete?

007vasy commented 2 years ago

sorry man, thanks for the heads up I need to rethink this

BobTheBuidler commented 2 years ago

@007vasy sounds good, we'll be here when you're ready! In the meantime I'm going to go ahead and close both this one and #24