banyansecurity / terraform-aws-banyan-accesstier2

Apache License 2.0
1 stars 8 forks source link

Add port 9998 listener and target group for healthcheck #15

Open pato-macrometa opened 10 months ago

pato-macrometa commented 10 months ago

Overview

This PR adds a port 9998 listener and target group for health checks to the Banyan repository's Terraform configuration. These enhancements are designed to improve network health monitoring and align with Banyan's infrastructure standards.

Changes Made

  1. AWS Load Balancer Target Group Configuration:

    • Added a new AWS Load Balancer Target Group aws_lb_target_group named target9998.
    • Configured with TCP protocol on port 9998, aligned with Banyan's requirement for specific port management.
    • Stickiness and health check features are configured to ensure robustness and reliability.
  2. AWS Load Balancer Listener Configuration:

    • Established aws_lb_listener for the Load Balancer, using the same TCP protocol on port 9998.
    • Default action set to forward traffic to the newly created Target Group.

Alignment with Banyan Documentation

Intent and Impact

yoshiotu commented 7 months ago

If I understand this correctly, it's adding one more listen port to the load balancer. Netagent's port 9998 health check should be called internally for the target group health check, but maybe it's not desirable to expose it publicly.