search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
368 stars 284 forks source link

[prometheus-operator-standalone] Allow Helm to deploy CRDs too #1260

Closed julianxhokaxhiu closed 2 years ago

julianxhokaxhiu commented 3 years ago
Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #1257
License Apache 2.0

What's in this PR?

Starting Helm v3 it is possible to deploy CRD manifests automatically when installing a chart, by simply placing manifests inside a folder named "crds".

As the chart provides the manifests already, all we have to do is rename the folder name in order to fit with the new Helm v3 workflow.

Why?

Simplify the chart installation and use entirely helm to manage it, without the need to go custom with partially using kubectl and partially helm.

Additional context

This change has already been tested on top of Kubernetes 1.19, where previously were returning an error ( see the issue description ).

Checklist

julianxhokaxhiu commented 3 years ago

Sorry for the multiple description edits, but I finally sorted out why mergeable was complaining and I finally got it right. Let me know if anything else is needed to get this PR merged. Thank you!