Closed auricom closed 2 years ago
Describe the bug Prometheus community changed prometheus nodelabel in Helm Chart 16.1.x https://github.com/prometheus-community/helm-charts/commit/2411d15017d5b673fc8c211ea20616534eb8e6e4#diff-a5376d240d3c8079c0639e2ca8ff06c837a7c8db7e7529415a637423934977a1
Banzaicloud Thanos helm chart is forcing to use the old naming convention https://github.com/banzaicloud/banzai-charts/blob/master/thanos/values.yaml#L1060, making sidecar service to not be attached to prometheus containers
Expected behavior Default sidecar selector default values should be erasable
Describe the bug Prometheus community changed prometheus nodelabel in Helm Chart 16.1.x https://github.com/prometheus-community/helm-charts/commit/2411d15017d5b673fc8c211ea20616534eb8e6e4#diff-a5376d240d3c8079c0639e2ca8ff06c837a7c8db7e7529415a637423934977a1
Banzaicloud Thanos helm chart is forcing to use the old naming convention https://github.com/banzaicloud/banzai-charts/blob/master/thanos/values.yaml#L1060, making sidecar service to not be attached to prometheus containers
Expected behavior Default sidecar selector default values should be erasable