Support to modify the log level key name in the cadence

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform

Apache License 2.0

368 stars 283 forks source link

Support to modify the log level key name in the cadence #1293

Closed git-hulk closed 2 years ago

git-hulk commented 3 years ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	no
Related tickets	no
License	Apache 2.0

What's in this PR?

Support to modify the log level key name in the cadence

Why?

The log level key was used to identify which field in the log JSON was represented the log level and regard the log as ERROR level when the log level key was not found, so we want to have a way to change log level key(default was "level").

Checklist

[x] Code meets the Developer Guide
[x] User guide and development docs updated (if needed)
[x] Related Helm chart(s) updated (if needed)

git-hulk commented 3 years ago

Many thanks to @pregnor, it's enough in the next release since we can workaround with local charts and use the remote repo agnain after releasing.

pregnor commented 2 years ago

@git-hulk I hope it is okay if we are going to rebase the PR to the latest master state and also push a chart patch version bump commit before merging. It is easier and faster for us to release a patch version this way.

@akijakya is going to do these changes and the release in the coming hours.

git-hulk commented 2 years ago

Many thanks to @pregnor, we have patched the change on our local version, and works fine now. Would switch to the community version again after release.

akijakya commented 2 years ago

Hi @git-hulk!

The new chart version 0.22.1 has been released containing this change. You can pull the new chart after updating your local Helm repository index.

Note that the server version has also been bumped in the meantime 0.21->0.22.